Fix leftover whitespace, metadata errors

This commit is contained in:
Florian Heilmann 2023-12-21 01:45:44 +01:00
parent cfdb009ee9
commit 1ea13aafc2
65 changed files with 62 additions and 180 deletions

View File

@ -1,13 +0,0 @@
on:
workflow_run:
workflows: ["VoronUsers PR CI"]
types:
- completed
jobs:
create_pr_comment:
permissions:
pull-requests: write
name: Create PR comment and assign labels
if: ${{ github.event.workflow_run.event == 'pull_request' }}
uses: VoronDesign/.github/.github/workflows/pr-comment-labels.yml@main

View File

@ -1,4 +1,4 @@
name: VoronUsers PR CI
name: pull_request_ci
run-name: "#${{github.event.number}} - ${{github.event.pull_request.title}}"
on:
pull_request:
@ -9,90 +9,5 @@ concurrency:
permissions:
pull-requests: write
jobs:
check_whitespace:
uses: VoronDesign/.github/.github/workflows/check-whitespace-cache.yml@main
with:
branch: ${{ github.ref }}
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
parent-job-name: check_whitespace
setup_python:
needs: [check_whitespace]
if: ${{ needs.check_whitespace.outputs.stl == 'true' }}
uses: VoronDesign/.github/.github/workflows/prepare-environment.yml@main
with:
apt-packages: "admesh, libadmesh-dev"
pip-packages: "admesh imagekitio git+https://github.com/ChristophSchranz/Tweaker-3.git"
python-cache-key: voronusers-python-cache
check_stl_corruption:
needs: [setup_python]
if: ${{ needs.check_whitespace.outputs.stl == 'true' }}
uses: VoronDesign/.github/.github/workflows/check-stl-corruption.yml@main
with:
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
python-cache-key: voronusers-python-cache
parent-job-name: check_stl_corruption
check_stl_rotation:
needs: [setup_python]
if: ${{ needs.check_whitespace.outputs.stl == 'true' }}
uses: VoronDesign/.github/.github/workflows/check-stl-rotation.yml@main
with:
imagekit-url-endpoint: https://ik.imagekit.io/vorondesign
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
python-cache-key: voronusers-python-cache
parent-job-name: check_stl_rotation
check_metadata:
needs: [check_whitespace]
if: ${{ needs.check_whitespace.outputs.yaml == 'true' }}
uses: VoronDesign/.github/.github/workflows/check-metadata-files.yml@main
with:
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
parent-job-name: check_metadata
preview_readme:
needs: [check_metadata]
uses: VoronDesign/.github/.github/workflows/preview-readme.yml@main
with:
subdirectory: printer_mods
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
parent-job-name: preview_readme
prepare_pr_comment:
# Dispatching allows us to run in the context of our repo, with sufficient credentials to do PR comments/set labels. We pass the
# information that the dispatched workflow can't deduce on its own via the client payload parameter
needs: [check_whitespace, check_stl_corruption, check_stl_rotation, check_metadata, preview_readme]
if: ${{ always() }}
runs-on: ubuntu-latest
steps:
- name: Save PR number
run: |
mkdir -p ${{ runner.temp }}/pr
echo -n "Ready for review" > ${{ runner.temp }}/pr/ready_label
echo -n ${{ github.event.number }} > ${{ runner.temp }}/pr/pr_number
echo -n ${{ github.run_id }} > ${{ runner.temp }}/pr/action_run_id
mkdir -p ${{ runner.temp }}/pr/check_stl_corruption
echo -n ${{ needs.check_stl_corruption.outputs.extended-outcome }} > ${{ runner.temp }}/pr/check_stl_corruption/result
echo -n ${{ needs.check_stl_corruption.outputs.numeric-job-id}} > ${{ runner.temp }}/pr/check_stl_corruption/job_id
echo -n "CR: STL Corruption" > ${{ runner.temp }}/pr/check_stl_corruption/error_label
mkdir -p ${{ runner.temp }}/pr/check_stl_rotation
echo -n ${{ needs.check_stl_rotation.outputs.extended-outcome }} > ${{ runner.temp }}/pr/check_stl_rotation/result
echo -n ${{ needs.check_stl_rotation.outputs.numeric-job-id}} > ${{ runner.temp }}/pr/check_stl_rotation/job_id
echo -n "CR: STL Rotation" > ${{ runner.temp }}/pr/check_stl_rotation/error_label
mkdir -p ${{ runner.temp }}/pr/check_whitespace
echo -n ${{ needs.check_whitespace.outputs.extended-outcome }} > ${{ runner.temp }}/pr/check_whitespace/result
echo -n ${{ needs.check_whitespace.outputs.numeric-job-id}} > ${{ runner.temp }}/pr/check_whitespace/job_id
echo -n "CR: Files & Folders" > ${{ runner.temp }}/pr/check_whitespace/error_label
mkdir -p ${{ runner.temp }}/pr/check_metadata
echo -n ${{ needs.check_metadata.outputs.extended-outcome }} > ${{ runner.temp }}/pr/check_metadata/result
echo -n ${{ needs.check_metadata.outputs.numeric-job-id}} > ${{ runner.temp }}/pr/check_metadata/job_id
echo -n "CR: Metadata Files" > ${{ runner.temp }}/pr/check_metadata/error_label
mkdir -p ${{ runner.temp }}/pr/preview_readme
echo -n ${{ needs.preview_readme.outputs.extended-outcome }} > ${{ runner.temp }}/pr/preview_readme/result
echo -n ${{ needs.preview_readme.outputs.numeric-job-id}} > ${{ runner.temp }}/pr/preview_readme/job_id
echo -n "CR: Readme Preview" > ${{ runner.temp }}/pr/preview_readme/error_label
- uses: actions/upload-artifact@65d862660abb392b8c4a3d1195a2108db131dd05
with:
name: pr
path: ${{ runner.temp }}/pr
voronusers_ci_pr_check:
uses: VoronDesign/.github/.github/workflows/voronusers-ci-pr-check.yml@main

View File

@ -0,0 +1,11 @@
on:
workflow_run:
workflows: ["pull_request_ci"]
types:
- completed
jobs:
post_process_pr_ci:
if: ${{ github.event.workflow_run.event == 'pull_request' }}
uses: VoronDesign/.github/.github/workflows/voronusers-ci-pr-postprocess.yml@main

View File

@ -4,20 +4,6 @@ on:
branches:
- 'main'
jobs:
setup_python:
name: Rebuild repo caches
uses: VoronDesign/.github/.github/workflows/prepare-environment.yml@main
with:
apt-packages: "admesh, libadmesh-dev"
pip-packages: "admesh imagekitio git+https://github.com/ChristophSchranz/Tweaker-3.git"
python-cache-key: voronusers-python-cache
preview_readme:
name: Generate README
uses: VoronDesign/.github/.github/workflows/generate-readme.yml@main
with:
subdirectory: printer_mods
commit_msg: "Generate VoronUsers printer_mods README.md [skip ci]"
commit_user: Voron-GitHub-Bot
commit_email: github@vorondesign.com
secrets:
VORON_BOT_GITHUB_PAT: ${{ secrets.VORON_BOT_GITHUB_PAT }}
voron_ci_push_main:
name: VoronCI push main
uses: VoronDesign/.github/.github/workflows/voronusers-ci-push-main.yml@main

View File

@ -1,17 +0,0 @@
on:
workflow_run:
workflows: ["VoronUsers PR CI"]
types:
- completed
jobs:
upload_imagekit:
if: ${{ github.event.workflow_run.event == 'pull_request' }}
uses: VoronDesign/.github/.github/workflows/upload-artifact-imagekit.yml@main
with:
artifact_name: pr_rotated_stls
images_subfolder: img
imagekit-url-endpoint: https://ik.imagekit.io/vorondesign
secrets:
IMAGEKIT_PRIVATE_KEY: ${{ secrets.IMAGEKIT_PRIVATE_KEY }}
IMAGEKIT_PUBLIC_KEY: ${{ secrets.IMAGEKIT_PUBLIC_KEY }}

View File

@ -3,16 +3,16 @@ cad:
- cad/cable_routing_z_belt_cover_a_mod_rail_notch_v2.4.step
- cad/cable_routing_z_belt_cover_a_mod_v2.2.step
- cad/cable_routing_z_belt_cover_a_mod_v2.4.step
- cad\cable_routing_z_belt_cover_b_mod_rail_notch_v2.2.step
- cad\cable_routing_z_belt_cover_b_mod_rail_notch_v2.4.step
- cad\cable_routing_z_belt_cover_b_mod_v2.2.step
- cad\cable_routing_z_belt_cover_b_mod_v2.4.step
- cad/cable_routing_z_belt_cover_b_mod_rail_notch_v2.2.step
- cad/cable_routing_z_belt_cover_b_mod_rail_notch_v2.4.step
- cad/cable_routing_z_belt_cover_b_mod_v2.2.step
- cad/cable_routing_z_belt_cover_b_mod_v2.4.step
description: Z belt covers that allow hidden cable routing.
images:
- img/cable_routing_z_belt_cover_mod_v2.2_img_2.png
- img/cable_routing_z_belt_cover_mod_v2.2_img_2.jpg
- img/cable_routing_z_belt_cover_mod_v2.2_img_0.png
- img/cable_routing_z_belt_cover_mod_v2.2_img_1.png
- img/cable_routing_z_belt_cover_mod_v2.2_img_3.png
- img/cable_routing_z_belt_cover_mod_v2.2_img_3.jpg
- img/cable_routing_z_belt_cover_mod_v2.4_img_0.png
- img/cable_routing_z_belt_cover_mod_v2.4_img_1.png
- img/cable_routing_z_belt_cover_mod_rail_notch_v2.4_img_2.png

View File

@ -1,6 +1,6 @@
cad:
- CAD/Retractor Mount Straight.f3d
- CAD/Retractor Mount Slanted.f3d
- CAD/Retractor_Mount_Straight.f3d
- CAD/Retractor_Mount_Slanted.f3d
description: Extrusion mount for badge retractor to keep bowden tube out of the way.
images:
- Images/Image.jpg

View File

@ -1,5 +1,5 @@
cad:
- Parametric Filtered Power v1.8.f3d
- Parametric_Filtered_Power_v1.8.f3d
description: V1.6 Filtered Inlet and Rocker Switch for V1.8
images:
- pictures/Front.png

View File

@ -1,5 +1,5 @@
cad:
- CAD/Ender3SW v2.f3d
- CAD/Ender3SW_v2.f3d
description: Mod for the Ender 3 and Ender 3 Pro, which adapts the kinematics and
most other parts of the Voron Switchwire.
images:

View File

@ -1,6 +1,6 @@
cad:
- CAD/Handle_Mini_Front.step
- CAD/Door Frame.step
- CAD/Door_Frame.step
- CAD/Door_Latch_x2.step
description: Door in a frame
images:

View File

@ -1,6 +1,6 @@
cad:
- CAD/Filter Cage.step
- CAD/Fan Mounting.step
- CAD/Filter_Cage.step
- CAD/Fan_Mounting.step
- CAD/HEPA_Filter.step
description: "Filter case with fan\xB4s"
images:

View File

@ -1,6 +1,6 @@
cad:
- CAD/Panel right.step
- CAD/Panel left.step
- CAD/Panel_right.step
- CAD/Panel_left.step
description: Panels with intergrated hinge
images:
- Images/1.jpg

View File

@ -53,7 +53,7 @@ images:
- Printers/v1.8_v2.4_Legacy_Trident/Photos/probe_v1_underside_marked_magnets.jpg
- Printers/v1.8_v2.4_Legacy_Trident/Photos/AB_mount_press_Helper_inuseBack.jpg
- Printers/v1.8_v2.4_Legacy_Trident/Photos/klicky_v1.8_v2.4_Legacy_Trident.jpg
- Printers/v1.8_v2.4_Legacy_Trident/Photos/Klicky_Probe installed.png
- Printers/v1.8_v2.4_Legacy_Trident/Photos/Klicky_Probe_installed.png
- Printers/v1.8_v2.4_Legacy_Trident/Photos/Probe_MStoArrow_alignment.jpg
- Printers/v1.8_v2.4_Legacy_Trident/Photos/AB_mount_press_Helper_inuseTop.jpg
- Printers/v1.8_v2.4_Legacy_Trident/Photos/probe_dock_complete.jpg

View File

@ -1,5 +1,5 @@
cad:
- Tension Meter.f3d
- Tension_Meter.f3d
description: Print in place tension meter to easily tighten multiple belts to the
same tension
images:

View File

@ -1,6 +1,6 @@
cad:
- CAD/Trident_2.4_ComboInletSkirt v8.f3d
- CAD/Trident_2.4_ComboInletSkirt v8.step
- CAD/Trident_2.4_ComboInletSkirt_v8.f3d
- CAD/Trident_2.4_ComboInletSkirt_v8.step
description: Skirt pieces for Trident, 2.4 and 2.4r2 for combo inlets in 2 sizes.
images:
- ComboInlets.png

View File

@ -1,7 +1,7 @@
cad:
- CAD/Mantis_MGN12_CrazyVolcano_v1.0.step
- CAD/Mantis_MGN12_Dragon_v1.041_and_v1.043e.step
- CAD/Mantis_MGN12_Rapido_and Rapido_UHF.step
- CAD/Mantis_MGN12_Rapido_and_Rapido_UHF.step
- CAD/Mantis_MGN9_v1.0a.step
description: MGN12 Dual 5015 Toolhead for 2.4 & 1.8
images:

View File

Before

Width:  |  Height:  |  Size: 2.2 MiB

After

Width:  |  Height:  |  Size: 2.2 MiB

View File

Before

Width:  |  Height:  |  Size: 2.3 MiB

After

Width:  |  Height:  |  Size: 2.3 MiB

View File

@ -1,5 +1,5 @@
cad:
- Dioder Led Mount.step
- Dioder_Led_Mount.step
description: A mount for the IKEA Dioder LED strip
images:
- Dioder_Led_Mount_Render_1.png

View File

@ -1,7 +1,7 @@
cad: []
description: Modified chain mount position to cater for difference with Galileo Clockwork
images:
- switchwire chain.jpeg
- switchwire_chain.jpeg
mod_version: 1
printer_compatibility:
- VSW

View File

@ -1,6 +1,6 @@
cad:
- cad/v0_3x3_wago v2.f3d
- cad/v0_3x3_wago v2.step
- cad/v0_3x3_wago_v2.f3d
- cad/v0_3x3_wago_v2.step
description: Easy to install Wago mounts for v0 mains
images:
- images/mains_wago_v0_1.jpeg

View File

@ -1,6 +1,6 @@
cad:
- CAD/Z_Shaft_Assembly_12mm v8.f3d
- CAD/Z_Shaft_Assembly_12mm v8.step
- CAD/Z_Shaft_Assembly_12mm_v8.f3d
- CAD/Z_Shaft_Assembly_12mm_v8.step
description: Add V1.8 option for 12mm Z rods
images:
- Images/12mm_Z_Mod.png

View File

@ -1,5 +1,5 @@
cad:
- CAD/Trident_internal_spool_holder_001 v32.step
- CAD/Trident_internal_spool_holder_001_v32.step
description: Internal spool holder for 300 and 350 Tridents. Supports full size 1kg
spool
images:

View File

@ -1,8 +1,8 @@
cad:
- Hinges v2.4 Mod.f3d
- Hinges_v2.4_Mod.f3d
description: Simple mod of print in place door hinges, which uses m3 screws as shafts.
images:
- Door Hinges mod with M3 35mm.png
- Door_Hinges_mod_with_M3_35mm.png
mod_version: 1
printer_compatibility:
- V2.4

View File

@ -1,5 +1,5 @@
cad:
- CAD/NewLatch v108.f3d
- CAD/NewLatch_v108.f3d
description: Quick release panel latch inspired by the work of others.
images:
- Images/Latch-v68-3mm.jpg

View File

@ -1,5 +1,5 @@
cad:
- DIN rail 2020 holder.f3d
- DIN_rail_2020_holder.f3d
description: Attaching DIN Rails to 2020
images: []
mod_version: 1

View File

@ -1,5 +1,5 @@
cad:
- Exhast Housing Side Fitting.f3d
- Exhast_Housing_Side_Fitting.f3d
description: Moves the exhaust housing bowden fitting 90 degrees to allow the printer
to stand closer to a wall
images:

View File

@ -1,7 +1,7 @@
cad:
- cad/motor_mounts v1.f3d
- cad/xz blocks v3.f3d
- cad/upper_xz v6.f3d
- cad/motor_mounts_v1.f3d
- cad/xz_blocks_v3.f3d
- cad/upper_xz_v6.f3d
description: Small mods to belt routing components to ensure a better/more robust
alignment
images: